search

71 / BeatSinger

Beat Saber plugin for displaying floating lyrics while playing the game.
MIT License
46 stars 10 forks source link

Trouble with .srt Lyrics #9

Closed Shinjula closed 5 years ago

Shinjula commented 5 years ago

I'm trying to write my own custom Lyrics files for BeatSinger. I've written a program to help reposition the subtitles so they correctly match up to the audio, but i'm having trouble getting the lyrics to display ingame. I get the "Lyrics found locally" message and no error message, and nothing in the log files that I can see but the lyrics don't turn up. Can you shed some light on where the problem might be.

I've got the lyrics in the song directory and correctly called "lyrics.srt" and this is the test file I'm currently using lyrics.zip

71 commented 5 years ago

Your file doesn't appear to have a problem. Are you sure the lyrics are enabled? (press left or right stick while in game)

Shinjula commented 5 years ago

Yeah tried that

Shinjula commented 5 years ago

After realising that it wasn't just the srt files not working but all subtitles, including the online ones which worked before, I've uninstalled the game, deleted any remaining files and reinstalled both the game, my addons and custom songs (Do NOT forget to back up your songs if anyone else is doing this), and it all seems to be working fine now.

Not sure what happened to stop it working, let me know here if you do find something. But I'm now a happy bunny. And keep on with the programming, thats an awesome plugin. Cheers

71 commented 5 years ago

Aww, sorry you had to resort to such a solution. I'm glad it worked though!

I don't really know what happened... Maybe a problem in the patching step performed by IPA? In any case let me know if you encounter this again.

Shinjula commented 5 years ago

Ooops sorry I though the issue had come back but it turned out this time I'd just had them disabled and I panicked. I dunno if this is helpful but you might want to consider making a change to the "Lyrics Found" notification when the subtitles are off (which was partly what confused me), or maybe some notification somewhere on the menu page or even ingame, probably off to the side somewhere out of the way

Shinjula commented 5 years ago

Oh and having the button being the same as the pause button meant that the notification of "Subtitles disabled" isn't actually visible, since its hidden behind the steam pause screen

71 commented 5 years ago

I've only tested this on an Oculus Rift, but it shouldn't be the same button as the Steam pause button. Instead it should simply toggle the lyrics without pausing the gameplay...

you might want to consider making a change to the "Lyrics Found" notification when the subtitles are off

I was actually debating this myself. I thought it was nice to have some feedback even though the lyrics are off, but I suppose your idea is better.

Shinjula commented 5 years ago

Pressing down on the controllers does pause the gameplay on the steam version. This is including when your plugin isnt present (so its not an error caused by your plugin).