71 / dance

Make your cursors dance with Kakoune-like modal editing in VS Code.
https://marketplace.visualstudio.com/items?itemName=gregoire.dance
ISC License
444 stars 56 forks source link

Some keybindings are incorrectly generated #14

Closed timjs closed 4 years ago

timjs commented 4 years ago

Some keybindings are set to unknown by VSCode. This probably has to do something with the generate script and the yaml source.

Till now I've found these keys do not work out of the box (including their alt-counterparts):

71 commented 4 years ago

I've worked a bit on this tonight and fixed most commands, but since I don't have a Qwerty keyboard I can use, there are commands I simply don't know how to get. Can you try finding the commands for &, [, ], { and }, please? Better yet, if you could find the right keybindings for all commands with unknowns in them, I will make sure to add them correctly!

timjs commented 4 years ago

Below you'll find all the keybindings which are set to [shift+][alt+]unknown on my system (macOS 10.14.6, VSCode 1.40.1, Qwerty keyboard).

Schermafbeelding 2019-11-19 om 10 50 24 Schermafbeelding 2019-11-19 om 10 50 35 Schermafbeelding 2019-11-19 om 10 50 46 Schermafbeelding 2019-11-19 om 10 50 54

From top to bottom, they should be assigned to:

s+7
a+,
s+.
a+0
a+9
/
s+'
]
[
s+`

s+]
s+[
s+/

s+a+7
s+,
s+a+.
s+a+-
s+a+0
s+a+9
a+/
a+]
a+[

s+a+]
s+a+[
s+a+/

PS I assumed Dance: Deindent (including incomplete indent) is the default > and Dance: Deindent the alternative.

71 commented 4 years ago

Thanks for the help! 8fb3f3ffd758e498c4e0553e9414b5ccb7130b26 should fix it.