Avoid file locking in concurrent access

71 / scoop-better-shimexe

A better shim.exe file for Scoop.

MIT License

72 stars 29 forks source link

Avoid file locking in concurrent access #11

Closed hasufell closed 3 years ago

hasufell commented 3 years ago

It appears that _wfopen_s could be the reason for a bug in: https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/154

where these shim binaries are called concurrently. An already running process may lock the shim file during the short parsing period and cause the other process to fail.

_wfsopen with _SH_DENYNO should allow other processes to acces the shimgen just fine.

hasufell commented 3 years ago

Note that I haven't fully verified whether that fixes our misery. @jneira

71 commented 3 years ago

Closing as #12 was merged.