search

71 / scoop-better-shimexe

A better shim.exe file for Scoop.
MIT License
72 stars 29 forks source link

1.2 does not work with `gitk` and `dot` #6

Open trajano opened 4 years ago

trajano commented 4 years ago

I reshimmed and found out that gitk no longer functions with the new shim. Reverting back to the original shims brought the functionality back.

71 commented 4 years ago

What do you mean by "no longer functions"? I can launch it through the shim without a problem here.

trajano commented 4 years ago

When I type gitk from the command line it does not show the gitk window

trajano commented 4 years ago

This is with 1.2 release

trajano commented 4 years ago

@71 were you able to replicate the bug?

rasa commented 4 years ago

I am using https://github.com/71/scoop-better-shimexe/releases/download/1.2/shim.exe and gitk works just fine from the command line on:


OS Name:                   Microsoft Windows 10 Pro for Workstations
OS Version:                10.0.18362 N/A Build 18362
System Type:               x64-based PC
Hotfix(s):                 4 Hotfix(s) Installed.
                           [01]: KB4506991
                           [02]: KB4503308
                           [03]: KB4509096
                           [04]: KB4507453
trajano commented 4 years ago

I'm on

C:\Users\trajano>ver

Microsoft Windows [Version 10.0.18947.1000]

I am running from "Windows Terminal"

rasa commented 4 years ago

Works for me with cmd.exe and under Windows Terminal (Preview) Version: 0.4.2382.0

71 commented 4 years ago

No one is able to repro for now so I doubt I can help. I'll take a look at it eventually, but I am extremely busy these days, so please don't expect a fix soon.

In any case, are you sure you used the right shim? Maybe you're still using the old one (you can compare their size to make sure you're using the latest version). Are you sure nothing else may cause it to crash? Does it work fine when invoked directly without the shim?

PS: Thanks for your help, @rasa. And thanks for finding all the bugs, @trajano! :p

trajano commented 4 years ago

Maybe it's just something on my setup. Hopefully no one else hits it.

rasa commented 4 years ago

@trajano Your build, 10.0.18947.1000, is a 20_H1 prerelease. See https://msbuilds.rg-adguard.net/.

Can you try a released version?

trajano commented 4 years ago

Just closing this for now it could be because I am on insider builds

trajano commented 4 years ago

Hmm found a laptop running the current release version of Windows 10 and I am getting the behaviour where gitk does not open up. I ran from Cmder and CMD using the 1.2 shim

Microsoft Windows [Version 10.0.18362.356]

$ which gitk
/c/Users/trajano/scoop/shims/gitk
trajano commented 4 years ago

Another app that does not work for me with the new shims is dot from graphviz. It is supposed to be a console mode application, but with the new shim it just goes back to the command prompt after starting.

71 commented 4 years ago

Thanks for the other program, I'll check it out. I'm still busy though, so I doubt I'll come up with a fix soon.

Edit: I'm still unable to repro with dot. It works fine as a command line utility on my end.

trajano commented 4 years ago

@71 thanks not really sure why afaik I am using your 1.2 shim. However, no one else has been reporting any issues so maybe it will get merged soon. I am sort of thinking it's a PATH issue.

mnghsn commented 2 years ago

I also notice this issue but somehow solved by just adding a character to the path.

path = C:\path_to_git\git.exe        # => doesn't work :(

path = C:\path_to_git\\git.exe       # => works by adding a slash.
path = C:\\path_to_git\git.exe       # => works by adding a slash.
path = C:\path_to_git\git.exe<space> # => works by adding a trailing space.
path = "C:\path_to_git\git.exe"      # => works by quoting the path.
path = "C:\path_to_git\git.exe       # => works even no ending quote.