search

721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.
https://721.dev
MIT License
17 stars 5 forks source link

Buying: paying the current owner and setting the new valuation should be separated #36

Closed will-holley closed 2 years ago

will-holley commented 2 years ago

Situation:

Buyer wants to set a higher self-assessed value but only pay the current owner their self assessed value.

Currently:

Buyer can buy at a price higher than the current owner's price; the current owner receives the entire amount. e.g. current = 1; new = 1.5; remit = 1.5

Proposed Solutions:

vicsn commented 2 years ago

Within the current buy model, to me it would indeed make the most sense to only let the buyer pay the current price. There is no rational incentive to pay more than the current price.

The current design could be worked around by buyers by only purchasing at currentPrice + 1wei then setting the price higher.

will-holley commented 2 years ago

The current rational incentive is to allow raising the price in a single transaction so the previous owner does not immediately swoop in and re-purchase it.

I've added the bug label as increasing price should be a separate behavior and currently exists as a (technically convenient or inconvenient, depending on your perspective and the current price) side effect.

will-holley commented 2 years ago

https://github.com/721labs/partial-common-ownership/pull/52