Add functionality to wrap ERC721 tokens

721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.

https://721.dev

MIT License

17 stars 5 forks source link

Add functionality to wrap ERC721 tokens #45

Closed vicsn closed 2 years ago

vicsn commented 2 years ago

Implements:

new deterministic unique wrapped token Id
a simple test
And re-ordered some test files. There is now a Test721PCOToken.sol, Test721Token.sol (without PCO functionality) and Test721Wrapper.sol

I hope you forgive some of the code style (variable name underscores, ordering, keeping it DRY) and missing tests, please let me know first if you think the architecture looks good! :)

will-holley commented 2 years ago

Going to take a look at this shortly. I hadn't touched the token-wrapper branch in awhile and there was some code in there that was removed in main. Can you rebase your branch against token-wrapper?