search

721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.
https://721.dev
MIT License
17 stars 5 forks source link

Token wrapper #46

Closed vicsn closed 2 years ago

vicsn commented 2 years ago

Same as https://github.com/721labs/partial-common-ownership/pull/45 (which closed accidentally) and rebased on origin/token-wrapper.

Implements:

new deterministic unique wrapped token Id
a simple test
And re-ordered some test files. There is now a Test721PCOToken.sol, Test721Token.sol (without PCO functionality) and Test721Wrapper.sol

I hope you forgive some of the code style (variable name underscores, ordering, keeping it DRY) and missing tests, please let me know first if you think the architecture looks good! :)

will-holley commented 2 years ago

Heads up: we're currently using Yarn as the package manager, and that's why there's no package-lock.json file presently. Please remove package-lock.json.

EDIT: I went ahead and removed the file.