Consolidate price and deposit updates into a single method

721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.

https://721.dev

MIT License

17 stars 5 forks source link

Consolidate price and deposit updates into a single method #49

Open will-holley opened 2 years ago

will-holley commented 2 years ago

Summary

Currently, updating price and deposit requires separate transactions. This increases the gas cost for users who want to, for example, increase their price and increase their deposit proportionally.

Changes

@721labs/lebron-pizza has already implemented this. Examine whether this method is effective (can the positive/negative deposit system be simplified?).

vicsn commented 2 years ago

I would defer any gas-optimization work for the near-term - moving to ETH Layer 2 or deploying to EVM-compatible low fee chains achieves more gains

will-holley commented 2 years ago

One of the goals behind this project is providing a codebase that can be forked and deployed on any EVM-compatible chain. Accepting architectural limitations with the hope that low-gas obfuscates them isn't a good precedent.