Closed vicsn closed 2 years ago
I'm looking forward to reviewing this.
As to your questions, I feel like @gravenp and @codynhat also have constructive ideas here.
Haven't had a chance to review yet, but just came across this Harberger NFT that just launched and is using Zora: https://harberger.tax/
I'm trying to connect with the builders now.
@gravenp I can't tell if it's broken or if their flavor isn't a perpetual auction.
I was just on a Twitter space with them and they're having troubles with pushing it live, so "broken." It appears that they're going for a periodic auction style which the owner manually(?) relists the item. Definitely a much different approach than the applications that I've seen, but it was likely forced by their desired to use Zora "now."
Hey! What packages are missing in the node packages?
If there’s a custom type of market module you want to propose that’s also an option.
We’re working on front end modules for purchasing and selling NFTs within a modal.
This PR is a proof of concept Zora integration. It partially implements:
There is a lot still left to do:
takeoverLease(...)
should be called somehow with a new valuation. But Zora'sfillAsk(...)
function doesn't offer the right interface. So for any exchange we integrate, a "harberger-specific" storefront has to be built. I'll have a look at the Zora ecosystem to see what that would look like - maybe existing websites are open to support the interface.if (listed) { do_something_with_listing() }
For now I have the following question: how should we test the integration? I wanted to deploy all Zora contracts to see how our contracts interact with them. However, not all Zora contracts are available (or at least, documented...) in the
@zoralabs
' packages. Therefore I added the entire Zora/v3 repo as a submodule now. It feels a bit redundant, but on the other hand it ensures we learn how the exchange contracts work.