721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.
https://721.dev
MIT License
17 stars 5 forks source link

WIP: Add Zora #59

Closed vicsn closed 2 years ago

vicsn commented 2 years ago

This PR is a proof of concept Zora integration. It partially implements:

There is a lot still left to do:

For now I have the following question: how should we test the integration? I wanted to deploy all Zora contracts to see how our contracts interact with them. However, not all Zora contracts are available (or at least, documented...) in the @zoralabs' packages. Therefore I added the entire Zora/v3 repo as a submodule now. It feels a bit redundant, but on the other hand it ensures we learn how the exchange contracts work.

will-holley commented 2 years ago

I'm looking forward to reviewing this.

As to your questions, I feel like @gravenp and @codynhat also have constructive ideas here.

gravenp commented 2 years ago

Haven't had a chance to review yet, but just came across this Harberger NFT that just launched and is using Zora: https://harberger.tax/

I'm trying to connect with the builders now.

will-holley commented 2 years ago

@gravenp I can't tell if it's broken or if their flavor isn't a perpetual auction.

gravenp commented 2 years ago

I was just on a Twitter space with them and they're having troubles with pushing it live, so "broken." It appears that they're going for a periodic auction style which the owner manually(?) relists the item. Definitely a much different approach than the applications that I've seen, but it was likely forced by their desired to use Zora "now."

iainnash commented 2 years ago

Hey! What packages are missing in the node packages?

If there’s a custom type of market module you want to propose that’s also an option.

We’re working on front end modules for purchasing and selling NFTs within a modal.