721labs / partial-common-ownership

This project aims to establish a standard, open source implementation of Partial Common Ownership for non-fungible tokens.
https://721.dev
MIT License
17 stars 5 forks source link

Consolidate ERC721 implementation and `TokenManagement.sol` #70

Closed will-holley closed 2 years ago

will-holley commented 2 years ago

Motivation

Modules that inherit from TokenManagement should be inheritable within Forge (#69) tests but are not because Token Management doesn't fully implement ERC721; this causes the compiler to require the Forge tests be marked as abstract contracts.

To replicate the error:

git checkout foundry
forge test
will-holley commented 2 years ago

https://github.com/721labs/partial-common-ownership/pull/71