search

7368697661 / Ultra-Lobster

Ultra Lobster offers a visually pleasing and comfortable working experience, with an emphasis on bringing rounded UI elements, modern design trends, and soft design choices to Obsidian.
MIT License
101 stars 8 forks source link

Creating cards on the canvas laggs #13

Open lukemt opened 1 year ago

lukemt commented 1 year ago

Hi!

I noticed that creating new cards on the canvas takes a long time, and it appears that the @import statement for the google fonts is causing a delay of approximately one second when creating new cards.

PipeItToDevNull already suggested using base64 fonts. In addition we would need to reduce the number of fonts that are being loaded.

Ideally we would only use the fonts that have been selected by the user, but I don't know if that's even possible.

The issue happens because the editor is implemented as an iframe which triggers the theme to be loaded when it loads.

I think we have to radically reduce the amount of fonts 😢

What do you think?

lukemt commented 1 year ago

Maybe we can include one or two default fonts and write a guide on how to change to a specific font using css snippets?

7368697661 commented 1 year ago

Hi!! First off, so sorry i haven't had time to work on the theme and thank you so much for testing this :) Work has been craaazy, but now with Origami in a stable (enough) state i really want to get Ultra Lobster caught up :)

i did some research this afternoon, and long story short i think our best bet for now is to sadly reduce our font count :( In the future, i think it will be best to eventually switch to scss, because we could maybe use @use and/or some combination of Style Settings? (Not to mention performance benefits... i just need to learn scss haha).

Someone had asked for something like type combos for headers and body text, we could include a few 'type palettes' in addition to color palettes. Users could still mix and match fonts we load for those palettes via Style Settings*, potentially. i feel like choices are still super important to the theme, but we could par down to a handful of special combinations (rosario + crimson pro is a great example).

If we went that route, we could always slowly add more combinations down the line!

*i also need to refactor the theme to be less jank and fully support style settings 😅

lukemt commented 1 year ago

No worries, glad to hear from you. I didn't know you were already working on the next theme 😅.

scss would provide some benefits but I don't see how it could solve this particular problem, because scss compiles to css, which means you end up with css anyways.

Type Palettes are a good idea. Most people are not capable of choosing a good set of fonts (I'm talking about myself 😅). I chose the default font of the theme, which somehow happens to be my favorite 🤷. Don't know if that's an accident.

Let me know if you have any questions or any other ideas you would like to descuss. I would be honered to help.

7368697661 commented 1 year ago

On Origami vs Ultra Lobster

Oh, it's complicated, but Origami was my Obsidian October theme; it is pretty similar to UL in some ways, but i:

a. didn't want to drastically alter UL b. wanted to work on something specifically for O_O c. felt like the design choices are fundamentally different, Origami is meant to be a lightweight workhorse theme that sticks much more closely to base Obsidian in some ways; UL, however, is meant to change the UI far more drastically and offer more customization options.

Maybe it's just me, but i felt it best to keep them separate (and practice writing a new theme so i can fix the 🍝 holding UL together). That being said, Ultra Lobster was never forgotten :)

Ultra Lobster

My concern was that people might want options, but i would love to offer maybe three options of curated font combinations. i love fonts, so if my obsession can help others, i sincerely hope to offer some options that people can grab "worry free" and focus on writing or working. Here is what i am thinking:

Palette 1: Serif UI, text, monospace, headers and titles Palette 2: Sans-Serif UI, text, monospace, headers and titles Palette 3, either:

Another thought is that Serif and Sans-Serif often go well together as Header/Title and body text, we could offer Serif-dominant and Sans-Serif-dominant palettes, alternatively?

Oh, may i ask what you would personally look for in type options for a theme? Sorry if that is a weird question, but i also considered a survey just to get some idea of what people might find helpful :)

7368697661 commented 1 year ago

Oh, also: i think the licensing is correct, but i want to make sure people can help/make changes/do whatever they want. If you want to do anything or help or anything just let me know if i need to do anything! i don't want to lock anything down haha, i am slightly new to git permissions in a public setting though lol

7368697661 commented 1 year ago

Pssst there should be an early preview of a new system pushed; let me know your thoughts; they can be found under style settings in type palettes :)

lukemt commented 1 year ago

Hey there!

Personally, I like to keep things simple and just have a few options that I know are going to look good. I love fonts when I see them, but it can be overwhelming trying to pick the perfect combination. But when I see the screenshots, I'm like "wow, this looks amazing". So for me, a small selection of tried-and-true combinations would be perfect.

As for my preferred font, I usually just stick with the default sans-serif. But the screenshots of Ultra Lobster have definitely caught my eye - that serif header with the sans-serif body text looks particularly cool. So offering serif-dominant and sans-serif-dominant palettes makes a lot of sense to me.

As for the licensing, it looks good to me - just the standard "do whatever you want with this" type of deal. Can't complain about that!

I'll definitely check out the latest push and let you know what I think. Thanks for all your amazing work on Ultra Lobster!

lukemt commented 1 year ago

Ah I forgot to mention: I think having the Origami Theme seperate makes total sense. I think a theme should be recognizable and maintain some distinct style and identity.

7368697661 commented 1 year ago

Ok, i finally finished half of what i wanted to accomplish with a refactor haha. i cleaned the code, redid a bunch of stuff (shadows always eluded me, finally fixed that), and started commenting out the sections. So far, it's running way faster, and it's a lot more stable. The cost right now was taking an axe to Style Settings and sub-themes for now. In the future, i want to finally set some of that up, and i think that would get us to a 1.0 release :) Let me know what you think! Hopefully, it will be a bit easier to extend and edit the theme moving forward.