7449 / BannerLayout

Support unlimited picture rotation BannerLayout, the minimum implementation of the code banner
Apache License 2.0
93 stars 20 forks source link

Whats happened if items count be too large (Question) #10

Closed IRMobydick closed 7 years ago

IRMobydick commented 7 years ago

Hi there, First of all thanks for this handy and useful library 👍

Some questions:

  1. can you share proguard rules?
  2. if items count be too large ( like 20 or greater!) whats happened to pager indicator dots? Is there any chance to get behavior like instagram?

thanks :)

7449 commented 7 years ago

Being overtime ...

7449 commented 7 years ago

perhaps you can set the width and height of the dots according to the density of the screen,

  BannerLayout.setDotsWidthAndHeight()   or   BannerLayout.setDotsMargin()
IRMobydick commented 7 years ago

Thanks for replying Well, yeah in some case we get data with dots.getCount >= 20! like this! screenshot_20170725-165518

At this image we got 28 image as gallery!

Is there any change to set limit for dots to scroll dots holder area like instagram app?! Another thing, if item be exactly 1, what happened? dot should appear? banner should get scroll?

7449 commented 7 years ago

see: https://github.com/7449/BannerLayout/blob/master/app/src/main/java/com/bannersimple/simple/issues/Issues10Activity.java

this may be what you want

IRMobydick commented 7 years ago

Thanks Bro. I'll check it now! 👍

IRMobydick commented 7 years ago

Ummmm... that was not exactly what i want dude :( You just change size of dots base on screen width and still, if items count be so large, dots size goes to be so small!! BTW thanks for effort 🙏 I'll try to overcome this issue and share it here :)

7449 commented 7 years ago

I installed instagram and did not see banner,so I do not know what you want the effect

IRMobydick commented 7 years ago

Check this out: https://www.instagram.com/p/BW8kTLNlCXE/ photo_2017-07-26_11-23-41

7449 commented 7 years ago

animations need your own implementation, this is just a simple example🤔🤔