search

74th / vscode-vim

vim emulator for Visual Studio Code
MIT License
215 stars 25 forks source link

Cleaned up code. Created additional interfaces. Added vscode-vim.d.ts #11

Closed benjaminRomano closed 8 years ago

benjaminRomano commented 8 years ago

Almost all the changes are just moving interfaces to vscode-vim.d.ts and creating interfaces for existing classes.

Some of the changes are just code clean up. For example in extensions.ts, I changed VimStyleEnums to just Enums like it used elsewhere.

74th commented 8 years ago

Thank for your request!

I think CommandFactory and VimStyle class should not be interface. They are a core function in VimStyle, so I do not want to increase the necessary procedures yet.

I think almost vimmer don't look at an current mode. Many extensions may use status bar, so I'm planing it as an option.

I'll fix VimStyleEnums soon.

benjaminRomano commented 8 years ago

It's better to have CommandFactory and VimStyle backed by interfaces. It makes testing easier.

I made the current mode a config setting in https://github.com/benjaminRomano/vscode-vim/commit/42fe7755b6f19aaa541dd62f9533f35c1bb4abe6. It is disabled by default.

A user can specify whether or not to show the mode in the status bar by adding this property to their configs:

    "vimStyle.showMode": true

Also, I fixed a bug with config properties in https://github.com/benjaminRomano/vscode-vim/commit/ed16cf9be78bd33f5f8e349b67214fc57b18f544

You were looking for "vimStyle.useJisKeyboard", but in the package.json it was set to "vimstyle.useJisKeyboard"

74th commented 8 years ago

Yes, I'll try as you said. Thanks.