Env variables not unloaded after moving outside directory with .envrc

worldmind commented 5 years ago

Hi, thanks for your project - it is that I need. But a couple of questions:

looks like env variables didn't unloaded

looks like direnv called more than one time

$ cd ~/projects/executor/
direnv: loading .envrc
direnv: export +PYTHONPATH
(executor)  $ $PYTHONPATH
EnvPath(
['/home/worldmind/projects/executor/lib']
)
direnv: loading .envrc
direnv: export +PYTHONPATH
(smart-executor)  $ cd ..
$ $PYTHONPATH
EnvPath(
['/home/worldmind/projects/executor/lib']
)
$

Ubuntu 18.04 with python3.7, direnv from snap, xonsh from pip (fresh install)

$ direnv --version
2.18.2
$ xonsh --version
xonsh/0.9.13.dev1
$ fgrep xontrib ~/.xonshrc
xontrib load vox
xontrib load avox
xontrib load direnv

con-f-use commented 5 years ago

Yes, known problem. See here: https://github.com/74th/xonsh-direnv/issues/2

def __direnv():
    p = subprocess.Popen(
        'direnv export json'.split(),
        stdout=subprocess.PIPE,
        env=__xonsh__.env.detype()
    )
    r, _ = p.communicate()
    if len(r) > 0:
        for k, v in json.loads(r).items():
            if v is None:
                del (__xonsh__.env[k])
            else:
                __xonsh__.env[k] = v

Best fix for now...

con-f-use commented 4 years ago

https://github.com/74th/xonsh-direnv/pull/7 should close this issue.

worldmind commented 4 years ago

Now works fine, thanks! It's great!

con-f-use commented 4 years ago

@74th, if you give me rights to this repo I could help manage it and e.g. close this issue.

74th / xonsh-direnv

Env variables not unloaded after moving outside directory with .envrc #5