search

75lb / table-layout

Styleable plain-text table generator. Useful for formatting console output.
MIT License
23 stars 6 forks source link

split into core and CLI packages #18

Closed benmccann closed 4 months ago

benmccann commented 4 months ago

Hi, I know this is a non-trivial unsolicited PR, but I hope you will find value in it and I would be happy to work to update it to match any preferences you have for.

This creates two packages within this repository: a core package and a CLI package. I would really like to use the core package from a number of projects, but they already have their own CLI libraries and I don't want to pull in additional CLI dependencies that will be unnecessary. This moves the dependencies command-line-args, command-line-usage, and stream-read-all out of core as well as their transitive dependencies, which is a majority of the project's dependencies: https://npmgraph.js.org/?q=table-layout

This PR is built using pnpm so that both projects can be built, tested, etc. with a single command.

I would say the main thing to decide is what should the package names be? Some possibilities:

I've also left the version numbers alone, but they would need to be incremented before or as part of any new release.

75lb commented 4 months ago

There used to be a separate table-layout-cli module but, for the sake of simplicity, the most recent table-layout release merged the two (see the Release Notes). I will take a look at the merits of splitting them up again tomorrow, once I get time.. Thanks for the report.

benmccann commented 4 months ago

Oh, interesting. I wasn't aware of that. Thanks for taking a look at this!

75lb commented 4 months ago

Released in v4.0.0, let me know if there's anything else..