search

7696122 / evil-terminal-cursor-changer

:smiling_imp: Chagning cursor by mode for evil on terminal.
81 stars 12 forks source link

Does not work in iTerm2 with Emacs 24.4.1 #3

Closed danielwuz closed 9 years ago

danielwuz commented 9 years ago

In latest Emacs version, this mode breaks.

I debugged a little bit, that's because variables etcc--evil-emacs-state-cursor evaluates to be a color value like "gray", rather than a shape symbol. Then all if condition failed in etcc--set-evil-cursor, therefore none of the set cursor function gets called, as in https://github.com/7696122/evil-terminal-cursor-changer/blob/master/evil-terminal-cursor-changer.el#L184

My emacs version:

"GNU Emacs 24.4.1 (x86_64-apple-darwin14.0.0, NS apple-appkit-1343.16)
 of 2015-01-09 on dawu.local"

Let me know if there's any information I can provide or anything I can do to help solve this problem.

7696122 commented 9 years ago

Sorry, I'm so late to fix this bug. I mistake evil cursor type setting.

My evil setting `'(bar "red"). so i use car to get first element.

but normally settings is `("red" bar)'.

So I make function for find "bar, box, box' symbol.

danielwuz commented 9 years ago

@7696122 It now works, just verified. Thanks very much for your hard work!