search

7Ji / archrepo

A pacman repo focusing on Arch as media center, for ArchLinux on x86_64 and ArchLinux ARM on aarch64, updated hourly
GNU Affero General Public License v3.0
26 stars 5 forks source link

mpp-git dependency on systemd for udev #18

Closed SputnikRocket closed 10 months ago

SputnikRocket commented 10 months ago

It would be desirable to replace the "systemd" dependency with "udev" this would allow non-systemd users to install the package, but also keep the needed dependencies, as systemd provides udev, while eudev provides udev on non-systemd systems.

Associated PR:

https://github.com/7Ji-PKGBUILDs/mpp-git/pull/2

has this been tested to build and install successfully on both systemd and non-sytemd systems?

Yes. I have.

7Ji commented 10 months ago

The tracking issue regarding PKGBUILDs should be opened at https://github.com/7Ji-PKGBUILDs/.report/issues , not here. This issue section is for stuffs directed related to releases packages, i.e. their binary form. But for this, let's keep it here.

This looks OK and could be merged. But could you elaborate on what environment you're / expect mpp to run in? My repo is only for Arch x86_64 and ALARM aarch64, not any other distro. So for that PR to the PKGBUILD, it's OK. But for this repo, it's kinda not.

SputnikRocket commented 10 months ago

Ok. thank you for clarifying.

7Ji commented 10 months ago

The package uploaded by the builder a couple of minutes ago should already contains the dep change, but you'll need a manual re-installation as the pkgver and pkgrel were not updated alongside.

SputnikRocket commented 10 months ago

but you'll need a manual re-installation as the pkgver and pkgrel were not updated alongside.

I guess should have incremented pkgrel in the PR as well. silly me

7Ji commented 10 months ago

but you'll need a manual re-installation as the pkgver and pkgrel were not updated alongside.

I guess should have incremented pkgrel in the PR as well. silly me

Not a big deal, the upstream updates pretty frequently, and I'd rather you keep the pkgrel unchanged than we need to drop a big pkgrel manually to 1 after a lot of upstream updates.