search

7digital / SevenDigital.Api.Wrapper

A fluent c# wrapper for the 7digital API
MIT License
16 stars 29 forks source link

Methods marked virtual #143

Closed gregsochanik closed 10 years ago

gregsochanik commented 10 years ago

A while ago Anthony marked some of the methods in the fluentApi class virtual:

https://github.com/7digital/SevenDigital.Api.Wrapper/blob/59b765883e4d5f9f2b9efa30117890ee30c947b1/src/SevenDigital.Api.Wrapper/FluentApi.cs

Has anyone got any idea why these were made virtual? Anyone mind if I remove it?

AnthonySteele commented 10 years ago

I have found an override of Please(). But not the other ones. I would recommend wrapping with a decorator over subclassing for this kind of thing.

AnthonySteele commented 10 years ago

Can we remove these in the run up to 4.0?

gregsochanik commented 10 years ago

Fine by me!

AnthonySteele commented 10 years ago

https://github.com/7digital/SevenDigital.Api.Wrapper/pull/174

AnthonySteele commented 10 years ago

Fix has been merged