Xml detection when the xml does not have the (optional) declaration

7digital / SevenDigital.Api.Wrapper

A fluent c# wrapper for the 7digital API

MIT License

16 stars 29 forks source link

Xml detection when the xml does not have the (optional) declaration #190

Closed AnthonySteele closed 10 years ago

AnthonySteele commented 10 years ago

See https://github.com/7digital/SevenDigital.Api.Wrapper/issues/189

Actual robust xml detection on IApiResponseDetector, The IsXml() method has been replaced with StartsWithXmlDeclaration() and IsWellFormedXml()

Can't guarantee that IsWellFormedXml is fast though, but this check only happens in cases where previously it would just throw. A better implementation on IsWellFormedXml is welcome!

AnthonySteele commented 10 years ago

No open issues :exclamation: :bowtie: Is that ready for a 4.1.0 release? :gift_heart:

gregsochanik commented 10 years ago

Yeah definitely! :thumbsup: