7digital / SevenDigital.Api.Wrapper

A fluent c# wrapper for the 7digital API
MIT License
16 stars 29 forks source link

Remove mutation that was adding extra query params #236

Closed danhaller closed 8 years ago

danhaller commented 8 years ago

POST endpoints with parameter substitution e.g. ~/foo/{bar} are not working after v7. The user is told that query string parameters cannot be used in combination with payloads, even if the parameter is substituted into the url.

I tracked this down to unintentional mutation in the RequestBuilder.BuildOAuthHeader method, which was adding the substitution parameters back in to the query string parameters after they had been removed.

I've fixed the mutation and renamed a couple of variables to make it a little clearer.

danhaller commented 8 years ago

Uh I've just realised I change the wrong test, will fix in a sec

danhaller commented 8 years ago

ok, done