7dir / aframe-svgfile-component

aframe svgfile
https://7dir.github.io/aframe-svgfile-component/
18 stars 6 forks source link

add support for lines, basic styles #12

Closed morandd closed 7 years ago

morandd commented 7 years ago

this adds support for lines and all geometric primitives.

i may have borked the build process a bit so feel free to hack that back into shape.

morandd commented 7 years ago

@7dir ping

7dir commented 7 years ago

code looks like *****

7dir commented 7 years ago

so we should separate version with SVGo and w/o it size become too big

7dir commented 7 years ago

@morandd ping

morandd commented 7 years ago

cleaned up code a bit & tried to fix the example.

I find the build toolchain daunting (ES6/ES5 cross-compiling, minification, browserify "-x" flag, etc) so apologies if the example doesn't run smoothly and that the .min.js is not small.

It is probably feasible to drop SVGO. The only thing it's doing is converting , , and a few other primitives into tags. It's not much more code to parse these primitives in extractSVGPaths(). We just need to convert the , etc tags into tags and return those synthetic tags along with the rest of the stuff from extractSVGPaths. Probably 10-30 lines of code.

I've got this running well enough for my needs right now so probably I won't contribute much more for now.

7dir commented 7 years ago

I thought use SVGO convert svg as services or/and cli command. Put SVGO inside package ... dirty style )))

Going review code.

@morandd thanks

PS Could I ask you some help? Maybe later?

morandd commented 7 years ago

not dirty style, with SVG inside the component simply works. one Githubissues.

  • Githubissues is a development platform for aggregating issues.