search

7even / endless-ships

Online reference to the Endless Sky game
http://endless-sky.7vn.io/
GNU General Public License v3.0
20 stars 10 forks source link

Add the Ka'het Ship file #9

Closed Zitchas closed 4 years ago

Zitchas commented 4 years ago

Adds the ship file for the Ka'het.

This is a new race that lives South of the Remnant in an area termed "The Graveyard." Added in 0.9.11

7even commented 4 years ago

Merged into the cljs branch and deployed to http://new.endless-sky.7vn.io/, please check (be sure to clear the browser cache).

Zitchas commented 4 years ago

I see them on the list there. Thanks for the update.

The only comment I have is that the race is known as the "Ka'het", no Kahet. If the framework can't handle the apostrophe I don't think that minor quibble is a big deal, but I just thought I'd point it out.

7even commented 4 years ago

The only comment I have is that the race is known as the "Ka'het", no Kahet. If the framework can't handle the apostrophe I don't think that minor quibble is a big deal, but I just thought I'd point it out.

Oops, my bad. Fixed.

Please review http://new.endless-sky.7vn.io/ one last time before it goes to http://endless-sky.7vn.io/ and http://dev.endless-sky.7vn.io/ (I will still use the latest development version of the game for the dev. version and the latest stable for the main one).

Zitchas commented 4 years ago

OK, overall, looks pretty good. Only two comments:

  1. The date next the ES commit version says (invalid date)
  2. Both Void Sprites are listed under a single entry. For clarity, they should be listed separately. Looking at the data, they are clearly two different ships, not just a variant.
7even commented 4 years ago
  1. The date next the ES commit version says (invalid date)

That's strange, it shows (2020-03-14) in my browser. Nevertheless I moved the date formatting code to the site generation step so now it should work correctly (I assume the problems were somewhere in the browser).

2. Both Void Sprites are listed under a single entry. For clarity, they should be listed separately. Looking at the data, they are clearly two different ships, not just a variant.

From what I see, this looks like a modification - like with human ships: ship "ship name" "modification name". Is there any other logic we should follow?

Zitchas commented 4 years ago

This is basically the exception, given that it is talking about the developmental stages of a living organism, and it is pretty much one of four actual living ships in the game. For every other ship in the game, the normal pattern works well.

That being said, I could probably see about getting the names changed to something along the lines of "Infant Void Sprite" and "Adult Void Sprite", but that's not a sure thing.

7even commented 4 years ago

That being said, I could probably see about getting the names changed to something along the lines of "Infant Void Sprite" and "Adult Void Sprite", but that's not a sure thing.

In my opinion this would be far better than adding numerous exceptions. Is that possible?

Zitchas commented 4 years ago

No guarantees. The player should never have one, so renaming it shouldn't necessitate the creation of a depreciated entry, but I'm not sure how likely it is that the Devs approve a renaming change just for consistency. I'll see what I can do, though.

Zitchas commented 4 years ago

Update: