search

7even / zodiac

A small gem for calculating zodiac sign from a date of birth
7even.github.com/zodiac
44 stars 22 forks source link

Chinese Sign #20

Open Sohair63 opened 6 years ago

Sohair63 commented 6 years ago

Is there any plan to implement Chinese Zodiac Signs in this repo?

7even commented 6 years ago

No, but you can propose a pull request - this feature seems to be pretty easy to implement. I would add it as a method in Zodiac::Finder and extend datetime classes with it in Zodiac::Date.

Sohair63 commented 6 years ago

Thanks, I will research a bit about Chinese Sign and get back to you with this implementation.