7gxycn08 / ForceAutoHDR

GUI That Forces Auto HDR In Unsupported Games.
Apache License 2.0
42 stars 0 forks source link

Force HDR has stopped working. #7

Closed Espnandro closed 4 months ago

Espnandro commented 4 months ago

It used to work just fine, but for the last few weeks I cannot force HDR on any of the programs I try. Again this used to work for me so it's not me misunderstanding how to find the correct exe or how to adjust the intensity slider, it only recently stopped forcing HDR. I'm wondering if perhaps W11 has broken the functionality with a recent update, or if I altered something that broke it.

Espnandro commented 4 months ago

Looking further, I realized it is making the necessary registry edit to force HDR in Computer\HKEY_CURRENT_USER\Software\Microsoft\Direct3D but it is naming programs incorrectly, I do not know if it has always named the exe files incorrectly or if it just started.

7gxycn08 commented 4 months ago

What game are you trying to enable AutoHDR for?

Edit: What's the exe name of the game?

Espnandro commented 4 months ago

Well, first I tried with brothers in arms hell's highway. When I saw it didn't work, I tried enabling it on Firefox as a test. Firefox also didn't work and misspelled in the registry, then I tried to test it again on the league client and once again it didn't work. I also know that it used to work on Firefox in the past because it was the exe I was using to test it before, and it did enable. Firefox notably doesn't support HDR video despite Edge and Chrome both supporting it, auto HDR on the browser was a nice workaround.

7gxycn08 commented 4 months ago

Found the bug and was able to replicate when adding Firefox. It is caused by inbuilt python function rstrip. exe_name.rstrip('.exe')

Screenshot 2024-04-28 115753

It's an easy fix will release a new version soon stay tuned and thanks for reporting it.

Would be nice if you can give me the name brothers in arms game so i can test if it gets registered properly.

Espnandro commented 4 months ago

Brothers_in_Arms_-_Hells_Highway_300x351 It's an old game I played when I was younger and recently just played through it again. I do not know if the game was misspelled in the registry or not, but the HDR did not enable for this game. I tried both windowed and full screen to try and fix the issue. Unfortunately, I cannot check the registry value because I already uninstalled the game and cleared it from the registry.

Would the HDR intensity slider enable for non fullscreen applications? For example, with Firefox, because it's a browser would that slider still enable, or would it apply the HDR with the slider still greyed out? I was trying to figure out if the HDR was correctly forced by checking the slider as suggested but if I remember correctly, in the past when I forced HDR on Firefox the slider did not enable, but the browser clearly had HDR, with the colors noticeably adjusting when I scrolled up and down the web page.

To be clear I did not use your GUI when forcing HDR in the past, I instead did it manually in the registry myself, I only recently started using this GUI for convenience.

7gxycn08 commented 4 months ago

Okay no problem.

I just released a fix for the incorrect name entries check it out here v1.0.0.3

I will close this issue now. Feel free to open a new one if you find a new issue.