7gxycn08 / PyAutoActions

Automatic Windows HDR Switching For Selected Proceses.
Apache License 2.0
28 stars 0 forks source link

HDR to SDR #3

Closed buzarini closed 1 month ago

buzarini commented 1 month ago

Hello! Please add the option to reverse switch HDR mode to SDR mode. I will be very grateful. Thank you in advance!

7gxycn08 commented 1 month ago

Can you give a use case example of what your trying to achieve?

buzarini commented 1 month ago

Can you give a use case example of what your trying to achieve?

I always use HDR in my monitor and dxvk for some games, but vulkan spoils the HDR colors after exiting the game. I need to switch the game from HDR to SDR, and after exiting the game, switch back from SDR to HDR.

7gxycn08 commented 1 month ago

PyAutoActions automatically switches from HDR to SDR when you quit the game. So just to be clear you would like to toggle HDR back on again after exiting the game?

buzarini commented 1 month ago

PyAutoActions automatically switches from HDR to SDR when you quit the game. So just to be clear you would like to toggle HDR back on again after exiting the game?

Game startup: PyAutoActions should switch HDR mode to SDR mode. (hdr --> sdr)

Game exit: PyAutoActions should switch SDR mode to HDR mode. (sdr --> hdr)

7gxycn08 commented 1 month ago

Requires complete rewrite of program logic.

7gxycn08 commented 1 month ago

Here is a test version can you check it out and see if it's working as intended?

Select the mode HDR 2 SDR from the GUI Toggle mode menu and test it out it should disable HDR when the game starts and enable HDR again when the game exits.

SDR 2 HDR mode will enable HDR at game start and disable HDR when the game exits.

Screenshot 2024-08-19 132016

Notice: added a 7z archive to a zip file because github does not support 7z format and max upload size is 25mb PyAutoActions.test.zip

buzarini commented 1 month ago

Select the mode HDR 2 SDR from the GUI Toggle mode menu and test it out it should disable HDR when the game starts and enable HDR again when the game exits.

HDR 2 SDR mode works great.

SDR 2 HDR mode will enable HDR at game start and disable HDR when the game exits.

I checked SDR 2 HDR mode and it doesn't work.

7gxycn08 commented 1 month ago

SDR 2 HDR mode will enable HDR at game start and disable HDR when the game exits.

I checked SDR 2 HDR mode and it doesn't work.

Make sure hdr is disabled when switching HDR 2 SDR to SDR 2 HDR

buzarini commented 1 month ago

Make sure hdr is disabled when switching HDR 2 SDR to SDR 2 HDR

I checked several times.

Game startup: PyAutoActions does nothing. (sdr)

Game exit: PyAutoActions switches SDR mode to HDR mode. (sdr --> hdr)

SDR 2 HDR logic at the moment.

The strangest thing is that version 1.1.7 has the same behavior.

7gxycn08 commented 1 month ago

Make sure hdr is disabled when switching HDR 2 SDR to SDR 2 HDR

I checked several times.

Game startup: PyAutoActions does nothing. (sdr)

Game exit: PyAutoActions switches SDR mode to HDR mode. (sdr --> hdr)

SDR 2 HDR logic at the moment.

The strangest thing is that version 1.1.7 has the same behavior.

It's working normally on my side.

Lets stick to the test version for now I changed the entire logic and just added an auto switch when switching toggle modes.

Restart your pc then test this new debug version(Console enabled by default to catch unwanted exceptions).

PyAutoActions.test-v2.zip

buzarini commented 1 month ago

It's working normally on my side.

Everything works fine.

The "Auto color management" function in w11 is to blame.

Thank you very much.

7gxycn08 commented 1 month ago

It's working normally on my side.

Everything works fine.

The "Auto color management" function in w11 is to blame.

Thank you very much.

Thanks for confirming.

I will add it in v1.1.8 and also some extra fixes.

7gxycn08 commented 1 month ago

Feature Added In v1.1.8