search

7max / log4cl

Common Lisp logging framework, modeled after Log4J
Apache License 2.0
103 stars 32 forks source link

minor issues with emacs support #8

Open bhyde opened 11 years ago

bhyde commented 11 years ago

The emacs support is delightful!

In this example...

cl-user> (log:info '(x y z) "yogurt for breakfast!")
 <INFO> [08:51:06]  (x y z) - yogurt for breakfast!
; No value
cl-user>

It seems to think yogurt is a function, but you and I know it's a dairy product.

Further, if you place the cursor on the close paren, well between the "z" and ")" and then bring up the context menu you get an ecase error. Yeah, ecase!

7max commented 11 years ago

Acknowledged, problem is Emacs side log4slime-highlight-log-message on Emacs needs to figure out there is no package, (backend already knows, thats why %g is printed as empty string).

Current logic says first bare word not in any kind of brackets is package.. Potential fix is to add a condition that it has to be before the "rest of the category" which is highlighted in function face.