7mind / izumi

Productivity-oriented collection of lightweight fancy stuff for Scala toolchain
https://izumi.7mind.io
BSD 2-Clause "Simplified" License
613 stars 66 forks source link

Handle null logger name for acceptable check #2145

Closed cholmes-axoni closed 2 months ago

cholmes-axoni commented 2 months ago

The acceptable check doesn't handle null logger names as the mkEntry does. This prevents it from failing for that null value.

This is an addition to a previous change. https://github.com/7mind/izumi/pull/1990

Let me know if this isn't the desired behavior and if records with null logger names should either always be accepted or never accepted.

[error]   NullPointerException
[error] 
[error]   StringOps.scala:836               scala.collection.StringOps$#split$extension
[error]   LogConfigServiceImpl.scala:21     izumi.logstage.api.routing.LogConfigServiceImpl#threshold
[error]   ConfigurableLogRouter.scala:38    izumi.logstage.api.routing.ConfigurableLogRouter#acceptable
[error]   LogstageJulLogger.scala:22        izumi.logstage.adapter.jul.LogstageJulLogger#publish
[error]   Logger.java:979                   java.util.logging.Logger#log