replaced acf_get_dir() with acf_get_url() to suppress notice from ACF

7studio / acf-svg-icon

Add a new ACF field type: "SVG Icon" which allows you to select icon(s) from a SVG sprite.

37 stars 10 forks source link

replaced acf_get_dir() with acf_get_url() to suppress notice from ACF #7

Open pixelspokefitz opened 4 years ago

pixelspokefitz commented 4 years ago

Hi there, this will resolve issue #6 would you mind publishing this to the WordPress repository?

hacknug commented 4 years ago

@pixelspokefitz according to #6 this was deprecated on v5.6.8 so the fix should only be applied for newer versions or at least those that actually include the method. Haven't checked if that's always been around or not though, so your changes may already be correct (pointing it out just in case).

7studio commented 4 years ago

Hi @pixelspokefitz,

Thank you for your contribution.

@hacknug is right. We need to have a backwards compatibility with the old versions of ACF and it's important to check which function we should used.

Can you update your PR to take into account this please?