search

7ute / symbols-list

An alternate symbol list sidebar for Atom.io text editor
GNU General Public License v3.0
32 stars 24 forks source link

UI positioning / Docks integration #42

Open onetrev opened 7 years ago

onetrev commented 7 years ago

I believe the Symbols List should display to the left, not the right, of Atom Tool Bar. Screenshot below... I believe most other packages display to the left of the Tool Bar, so hopefully it is an easy tweak.

image

This is a great addition to Atom though. Thank you so much for making this package! It's a big step up from Symbols Tree View package I had been using for ages.

onetrev commented 7 years ago

Related to this bug, a wishlist item for sure, but it would be awesome if is in fixing this bug Symbols List could be updated to make us of the coming "Docks" feature in Atom 1.17? Docks is easily one of the biggest / best new features in Atom since it went to v1.0 (in my opinion)!

7ute commented 7 years ago

Hi, Thanks your support! Indeed the upcoming "Docks" feature looks promising, and would simplify the sidebar management ( and allow moving it to other locations, cf. #31 ).

As for now, and the object of this ticket, I assume you're using flex-tool-bar, which relies on tool-bar. Unfortunatly, that package seems to rely on the default priority for the toolbar position. We could put a setting that allows to set a priority ( SymbolsList.coffee:46 ) superior to 100 (panels defaults, lower is closer to the edge). Or we could wait for the docks feature and see how it manages panels priorities?

onetrev commented 7 years ago

You're very welcome, but more so, thank you for working on this package! You are right, I am using tool-bar package (linked above in my initial issue request).

I know I've seen a number of other packages that seem to be correctly to the left of the tool-bar, but I can't find any right now unfortunately. I was trying to find one so I could check what they did. But for now, as it sounds like a quick fix, I would love to have that option added to resolve this in the short term. Please!

And it's cool that Docks could tackle multiple issues for you! Based on past Atom release timing, it should be in the production version of Atom (1.17) in the next few weeks at most.

onetrev commented 7 years ago

Found / remembered a package that displays correctly. The competing package to this one ;) ... Symbols Tree View. By default it appears nicely to the left side of Atom Tool Bar.

7ute commented 7 years ago

Might have to do with the loading priority, because after completely removing the priority in SymbolsList ( SymbolsList.coffee:46, removing 'priority:0' ) to mimic Symbols Tree View, the sidebar appears correctly on the left side. Then, if I restart, the sidebar moves further from the side, as depicted in your screenshot.

onetrev commented 7 years ago

And there we have it, Atom 1.17 is out, so Docks is now available to all and already in use by a number of packages (i.e. Linter-UI-Default and Tree View). So maybe we should just close out this issue and migrate to using Docks instead? Sounds easy to implement as well, though that's easy for me to say.

onetrev commented 7 years ago

I wonder if this bug shouldn't be closed (and a new one created regarding adding Docks support), or the title changed, because "Docks" is now fully part of Atom, and the recommended way for sidebar packages to be shown?

mbuc82 commented 7 years ago

Hey @onetrev ,

i guess you're right, as we are currently working on the Docks integration. I will not close this issue, but change the title in terms of better understanding.

Regards Marco