7ute / symbols-list

An alternate symbol list sidebar for Atom.io text editor
GNU General Public License v3.0
32 stars 24 forks source link

Windows command & customization #8

Open isteven opened 8 years ago

isteven commented 8 years ago

Hi,

Thanks for the great plugin, it really helps me!

Small bugs:

1) On the plugin settings page, I saw the default Mac toggle, which is alt-cmd-l. On Windows this would translate into alt-ctrl-l, but somehow it doesn't work. I know this can be configured manually, but I thought I'd just let you know.

2) When I click a function, it doesn't always bring me to the exact line, but sometimes 2-3 lines above.

Other than those, I would love to see further customization if possible, example:

Thanks & keep up the good work!

7ute commented 8 years ago

Hi, Thank you for your feedback :)

1/ Yeah, i should probably add some linux/windows dedicated shortcut. If alt-ctrl-l ain't taken already, that could do it. I don't have Atom installed on a windows machine so if you can confirm that this shortcut is free on vanilla atom, I'll add it. 2/ Ah yes, I noticed that one. It may have to do with some regexes matching line starting carriage returns ^^'. I'll fix that in next release.

As for the fine tuning, I was thinking of something like that. Maybe some sort of hierarchical table having sources types as parents, and symbols as children, and checkboxes to activate/deactivate sources or symbols. But that's a bit heavy for now, and by keeping the symbol list light, we may avoid the need of such settings? :)

Cheers!

isteven commented 8 years ago

Hi,

So far, I can confirm that no default Atom command using alt-ctrl-l / ctrl-alt-l. So it's still free.

Instead of a hierarchical table, perhaps you can just provide a simple textfield so people can just put a space-separated file types, such as:

Same for the symbols to show/hide, such as:

So basically they can be whitelist or blacklist, it's up to you. (However, for the symbols show/hide, you need to tell people what's settings are available).

Also, perhaps a simple legend is needed for the square icons you put in front of each function names. I'm a Javascript developer, and I saw "F" and "M". I'm sure "F" means function, but what is "M"?

Cheers.

7ute commented 8 years ago

"M" is for "Method" :) 1/ and 2/ Fixed on 2.2 release

Ill keep that ticket open, to get ideas when refactoring the settings!

isteven commented 8 years ago

Oh M for method.. silly me didn't realize it in the first place.

Thank you for the fixes, much appreciated, and, I look forward to the settings customization :)

Cheers.

isteven commented 8 years ago

Hi @7ute,

I have tested & I can confirm that the Windows shortcut is now working OK.

However, unfortunately problem no. 2) still exists. Also, upon further checking, it seems that it only happens on Functions (F). The Methods (M) seem to be spot on, at least from what I tested.

Cheers.

7ute commented 8 years ago

Oh that's true, thanks for noticing it! I forgot to fix that "jump to line" bug on JS. It seems to be ok for PHP though. It'll be done for next release :)