Closed yoshiyoshyosh closed 1 month ago
I'm not able to reproduce... does this happen with all URLs, or just that one?
does this happen with all URLs, or just that one?
all urls. I thought it was my vpn at first, so I disabled it and tried again--no dice. again, extremely odd that it's only happening with free-bandcamp-downloader, and not a bare python instance
EDIT: actually, it appears to only be happening in my python venv, not my machine's python environment. I'm able to reproduce in a bare python environment inside the venv, but not outside of it. this is extra odd and definitely not an issue with free-bandcamp-downloader...
It was urllib3. downgrading urllib3 from 2.2 to 1.26.x made it work again
related issue: https://github.com/urllib3/urllib3/issues/3439
closing since this isn't an issue with free-bandcamp-downloader
actually, this might be able to be worked around in free-bandcamp-downloader with a requirements.txt
to target <2
I'd rather not pin an old urllib3 dependency for all platforms since this bug only affects people running NixOS (?), but we can add a note in the README telling NixOS users that they should install the old version of urllib3.
I'm able to reproduce it on my distribution (void linux) inside a fresh python venv that's disconnected from the package manager. is it not reproducible for you with urllib 2.2.x?
I'm not able to reproduce on Armbian with urllib3 2.2.2
But I am able to reproduce on Mac...
Fixed in v0.3.4
Hello! urllib3 developer here. Bandcamp.com weirdly requires the TLS cipher suites that are used in urllib3 1.26.x, even if it does not use them. Here's the workaround to continue using urllib3 2.x: https://github.com/urllib3/urllib3/issues/3439#issuecomment-2306400349
Not sure when this started, since I haven't used this program for a while
line 367 is
which is odd, since all that
self.session
is is...self.session = requests.Session()
...and if I make the request from my own python instance...
what's going on here?