search

7yl4r / the-oregon-trajectory

:rocket: The Oregon Trail -- in SPAAACE!
http://7yl4r.github.io/the-oregon-trajectory/
GNU Affero General Public License v3.0
17 stars 6 forks source link

Sometimes percentFuel return 0 #112

Closed RyuIce closed 9 years ago

RyuIce commented 9 years ago

Sometimes percentFuel return 0, wich doesn't make sense with the displayed text.

7yl4r commented 9 years ago

You're right that the text doesn't work for 0 fuel, but I don't think this is the right solution.

Maybe we can have the text change based on the amount of fuel instead? (see debrisEncounter.getHarvestText)

RyuIce commented 9 years ago

Why is it written as a TODO commentary instead of the code itself? Is it because you don't want to mess with the code without something better instead of "Nothing of use here." and "Something..."?

7yl4r commented 9 years ago

That's exactly right! That's just filler text. We've got quite a but of that 'round these parts.

7yl4r commented 9 years ago

Thanks again for highlighting this issue. Hopefully that fix I just pushed improves things.