search

7yl4r / the-oregon-trajectory

:rocket: The Oregon Trail -- in SPAAACE!
http://7yl4r.github.io/the-oregon-trajectory/
GNU Affero General Public License v3.0
17 stars 6 forks source link

Fix issue #120 #122

Closed rotobash closed 9 years ago

rotobash commented 9 years ago

This should fix the spacemen being drawn over the text.

The z-index controls the stack order of the elements, I've set this to ten to ensure that it is the top element. Cheers.

rotobash commented 9 years ago

This particular solution doesn't look like that would work. I'll fix it and reopen it then. Sorry about that.

7yl4r commented 9 years ago

Does that fix not work? Looks good in theory, but I'm no css pro.

rotobash commented 9 years ago

I don't think it would have worked because the HTML needed some tweaking. I'm pretty sure z-indexing only applies to div tags. I changed the li tag to a p tag (unless it was supposed to be actually part of a bigger list?) and wrapped it in a div, the div tag now has the class game-over-text.

I will update it in my branch, but my linux distro is a bit buggered at the moment so I can't test it (using windows right now). Theoretically, it should work; practically, I don't know...

7yl4r commented 9 years ago

Alright, I'll watch and give it a test when it's ready.

On Sat, Jun 13, 2015, 7:22 PM thegluestickman notifications@github.com wrote:

I don't think it would have worked because the HTML needed some tweaking. I'm pretty sure z-indexing only applies to div tags. I changed the li tag to a p tag (unless it was supposed to be actually part of a bigger list?) and wrapped it in a div, the div tag now has the class game-over-text.

I will update it in my branch, but my linux distro is a bit buggered at the moment so I can't test it (using windows right now). Theoretically, it should work; practically, I don't know...

— Reply to this email directly or view it on GitHub https://github.com/7yl4r/the-oregon-trajectory/pull/122#issuecomment-111759881 .