7yl4r / the-oregon-trajectory

:rocket: The Oregon Trail -- in SPAAACE!
http://7yl4r.github.io/the-oregon-trajectory/
GNU Affero General Public License v3.0
17 stars 6 forks source link

game modules should use angular router #57

Closed 7yl4r closed 7 years ago

7yl4r commented 9 years ago

The controller/directive pairs used for game modules alongside $.show() and hide() are attempting to do routing, which is already a solved problem. Angular has a module which specifically addresses this. Benefits of switching to ng-router:

To maintain existing functionality the listeners set up in the Nodule class would also have to be adapted to use $locationChangeStart or similar instead of $on('swtichToModule',... To maintain modularity, each new route should be declared in the module's controller rather than having all of them in the main application.

7yl4r commented 7 years ago

closing this legacy issue to clear the issue tracker, but it remains open and tracked on the legacy project board