8-bit-sheep / googleAnalyticsR

Use the Google Analytics API from R
https://8-bit-sheep.com/googleAnalyticsR/
Other
259 stars 76 forks source link

Could not find function "register_theme_dependency" #417

Open MichaelMares opened 1 year ago

MichaelMares commented 1 year ago

What goes wrong

When loading the ga_model_example("ga-effect.gamr"), program executes and launches Oauth. As soon as authenticated, "An error has occurred! could not find function "register_theme_dependency""

I suspect that this function has been renamed in later versions of Shiny?

Is there a way to access the insides of ga_models and change the code inside? I enjoy that the auth process is handled but it seems like there are some older code snippets that cause these templates to fail.

I have tried downgrading Shiny to 1.6.0 and the issue persists. The same when updating to the latest version.

It would be amazing to get your help on this :)

Session Info

R version 4.1.3 (2022-03-10) Platform: aarch64-apple-darwin20 (64-bit) Running under: macOS 13.0.1

Matrix products: default LAPACK: /Library/Frameworks/R.framework/Versions/4.1-arm64/Resources/lib/libRlapack.dylib

locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages: [1] stats graphics grDevices datasets utils methods base

other attached packages: [1] gentelellaShiny_0.1.0 shinythemes_1.2.0 scales_1.2.1
[4] plotly_4.10.1 dygraphs_1.1.1.6 assertthat_0.2.1
[7] CausalImpact_1.3.0 bsts_0.9.9 xts_0.12.2
[10] zoo_1.8-11 BoomSpikeSlab_1.2.5 Boom_0.9.11
[13] googleAuthR_2.0.0 shiny_1.7.3 forcats_0.5.2
[16] stringr_1.5.0 dplyr_1.0.10 purrr_0.3.5
[19] readr_2.1.3 tidyr_1.2.1 tibble_3.1.8
[22] tidyverse_1.3.2 ggplot2_3.4.0 googleAnalyticsR_1.1.0

gronerik commented 2 months ago

@MichaelMares, thanks for reporting this! And sorry for the delay with our response (2 years!), it's been really busy with other projects and work, but trying to give some love to googleAnalyticsR again! :)

The Shiny's bootstrap.R seems to have the function in lowerCamelCase nowadays like registerThemeDependency, see: https://shiny.posit.co/r/reference/shiny/latest/registerthemedependency

So probably we just need to update the function names to fix this, like you said. Will have a look at this for the next googleAnalyticsR releases.