search

8080labs / ppscore

Predictive Power Score (PPS) in Python
MIT License
1.12k stars 168 forks source link

[Suggestion]: Plot the Decision Tree for pps.score #55

Open LaurenMcGarry opened 3 years ago

LaurenMcGarry commented 3 years ago

Would it be possible to create the ability to print the Decision Classifier Tree using pps.score? There might be a way to do this directly from my end, but I am currently unsure of how to do this. Thanks, Lauren

fwetdb commented 3 years ago

Thank you for the proposal! Since ppscore uses cross-validation, each fold calculates a different decision tree. Thus, you would need to choose which of the decision trees you want to inspect.

However, I guess the more important question is: Why do you want to do that?

LaurenMcGarry commented 3 years ago

I am using the equation as part of an analysis for my PhD, and I would like to show an example of one of the trees for context to the reader. It would be more of a 'nice to have', but I think it would add value for me!

Also, I noticed in the issue section, someone had mentioned about enabling a different type of validation that would suit time series data. Do you have any plans to implement this?

Thanks.

fwetdb commented 3 years ago

Understand - in this case, you might just train the Decision Tree separately (or in the same way) and then visualize this.

Regarding the time series data: we currently did not schedule time to work on this any time soon because we have no professional need for it right now but we are open to invest time supporting and guiding contributors who want to work toward this. Are you interested in this or what is your background with regard to that?