search

808loud / charlie-portfolio

http://chrlieco.com
0 stars 0 forks source link

Fixed button position in modal #30

Closed charlydsgn closed 8 years ago

charlydsgn commented 8 years ago

Can the X be static like the nav bar?

screen shot 2016-06-21 at 6 56 50 pm
808loud commented 8 years ago

In order to achieve the fixed positioning of an element inside a modal window, I needed to remove the transform property from the modal window. There should be little-to-no noticeable difference to the end user, but I wanted to note that according this this comment from a bootstrap core team member, removing the transform makes the modal window slightly less performant.

charlydsgn commented 8 years ago

Hmm, it would be nice to have the "X" fixed at the top to be consistent with all the other header nav functionality. I'd say go for it.

808loud commented 8 years ago

Shouldn't have any noticable impact. Pushed to master.