search

808loud / charlie-portfolio

http://chrlieco.com
0 stars 0 forks source link

Position footer buttons and modal arrow_up button 34px from bottom of viewport #55

Closed charlydsgn closed 8 years ago

charlydsgn commented 8 years ago

Padding should probably be consistent for the buttons. Match footer padding (below buttons) to header padding(above buttons). Treat the same for the modal buttons.

screen shot 2016-06-24 at 3 29 59 pm screen shot 2016-06-24 at 3 28 23 pm screen shot 2016-06-24 at 3 28 04 pm
808loud commented 8 years ago

Would love to do that, as it would really simplify my code and make my life easier... however, it would make the header nav bar narrower than the footer nav bar and the contact form.

If you want me to implement, I would be happy to revert the code that stretches them out. However, to reiterate, it will prevent me from justifying the header nav bar, the footer nav bar, and the contact form.

charlydsgn commented 8 years ago

Could you just add padding to the arrow in the modal then?

808loud commented 8 years ago

Arrow_up button is currently 50px wide to match up with the "static" X button in the modal.

It also has the same padding as all buttons (other than the header nav buttons, which have an additional 3px of padding-left and padding-right to justify the nav element).

How would you like me to change the arrow_up button's padding?

charlydsgn commented 8 years ago

Ah, I see that there is padding in chrome but not firefox. Why can't browsers get their act together! Lets just put this on the back burner for now unless it's a quick fix.

808loud commented 8 years ago

It ought to be the same, as I am using cross-browser compatible code to add style the buttons.

Is this related to browser zoom, perhaps?

charlydsgn commented 8 years ago

In Safari and Firefox the arrow button sits on the edge of the browser window, no padding. Padding only shows up in chrome.

charlydsgn commented 8 years ago

This isn't core to the functionality. I'd rather focus on the few things that are left, which I believe is the snapping of the nav bar to the right spot, the image not scaling above the contact form on my mobile device, and just noticed the work links do not work when I tap on my phone.

Going to lay low for a little bit and check-in on Sunday. Let me know when the site is ready and will give it one last look before going live.

808loud commented 8 years ago

Which work links are you referring to that are not working on your phone? Please open a new issue for that.

And now I see what you're referring to in this issue (#55). I was confused when you said padding... A web dev would call that margin. Or whitespace under the button would be universally understood ;-)

I will look into a fix later.

charlydsgn commented 8 years ago

Ha, in print I would call it margin too, and here I thought I was being savvy.