search

80O / PlusEMU

37 stars 28 forks source link

Async Call Chain #187

Closed Diddyy closed 7 months ago

Diddyy commented 1 year ago

From Joopie: Might wanna check out your async call chain. Your packet handler is still synchronous, because your GameClient's OnReceive method is being called inside a sync void method in both proxies. This can give strange behaviour and a potential deadlock.

Screenshot of a comment on RZ from Joopie.

I don't have time to check it atm but logging it here for future reference

80O commented 1 year ago

iirc Netcoreserver calles this method in an asynchronous manner.