80O / PlusEMU

39 stars 26 forks source link

Wardrobe & Figure manager #85

Closed IDjinn closed 2 years ago

IDjinn commented 2 years ago

TODO: when ClothingComponent will be refractored need update FigureDataManager.ValidateFigure logic

IDjinn commented 2 years ago

Should _figureDataManager.ProcessFigure moved into wardrobe manager logic?

80O commented 2 years ago

I would create a FigureValidator class and rename the process method to Validate

IDjinn commented 2 years ago

Yeah, I thought same. But if i touch that will need refract 😆

I will do soon

DamienJolly commented 2 years ago

I quite like the plus validator, but all the figure parts and colours should be stored in the database (similar to item_data -> furnidata). Then we can avoid loading in the xml file.

The only downside to this is that when you add new clothing you'll have to add a new entry into the database, but I don't see this being too much off an issue since its already done for items.

Imo, furnidata, figuredata ext should all be auto generated from the database anyway.

80O commented 2 years ago

I would follow Damiens suggestion and move all the xml stuff to the database. Add a command (console & room & rcon) to generate the XML files. For nitro we probably would have to generate some json files right?

IDjinn commented 2 years ago

For nitro we probably would have to generate some json files right?

I have no clue how nitro assets work, I appreciate help when need do that

McFluffy commented 2 years ago

It's probably not best to handle generating the XML/nitro files in the scope of the emulator. This functionality is best suited as a plugin or another external program.

80O commented 2 years ago

If we were to host it in the database for figure validation; anyone who runs this emulator has to rely on this feature or do the modifications twice.

Also there is no plugin system yet.

IDjinn commented 2 years ago

Done.

IDjinn commented 2 years ago

Outdated