879479119 / react-native-shadow

A SVG shadow component powered with react-native-svg,which can provide shadow on Android like iOS ^_^
MIT License
612 stars 82 forks source link

Calculation error in SVG Path #55

Open shubhangsati opened 3 years ago

shubhangsati commented 3 years ago

In BoxShadow, rectHeight is calculated as height - radius * 2 and rectWidth is calculated as width - radius * 2. These values can be negative for views with dynamic height. There should be a check for negative values before prefixing a - to a negative number (notice the double -- in the image below)  image

RuralPeople commented 2 years ago

+1