Rewrite manifest - Githubissues

89luca89 / io.github.luca.distrobox

Flatpak manifest for distrobox

GNU General Public License v3.0

17 stars 0 forks source link

Rewrite manifest #4

Closed ghost closed 2 years ago

ghost commented 2 years ago

x-checker-data is set up to make updating easier later (with flathubbot or GitHub Actions)
host-spawn is built locally so it will work with more architectures

Some thoughts:

Publish this on Flathub?
- flathubbot can automatically track version changes (and merge PRs)
Alternatively use GitHub Actions? https://github.com/marketplace/actions/flatpak-builder
Write a new script that downloads podman-static in $XDG_DATA_HOME when podman isn't detected on host?

ghost commented 2 years ago

OK I forgot the credits, should I add them back? The manifest is rewritten from the ground up though.

ghost commented 2 years ago

So you did local build before and later changed to fetching compiled binary directly.

Well, this is embarrassing. Shouldn't have rewrite it in the first place. But i'll leave this PR opened for now

89luca89 commented 2 years ago

I'm not against this at all I just did it because it was simpler, but it's the better approach clearly

89luca89 commented 2 years ago

About Flathub 2 thoughts on this:

1 - this is not nearly ready enough for prime time yet :P 2 - they already suggested me that this won't be accepted as it runs everything via host-spawn bypassing the sandbox