What would you think about additional functionality from the standard C4 library?

8T4 / c4sharp

C4Sharp (C4S) is a .net library for building C4 Model diagrams.

MIT License

261 stars 37 forks source link

What would you think about additional functionality from the standard C4 library? #19

Closed jtreher closed 2 years ago

jtreher commented 2 years ago

One thing I really like on the base Plantuml-stdlib is the ability to add version tags to show systems changing (planned deprecation, future systems). I think we could leverage this right out of the box with some additional configuration options on c4sharp's API but I wasn't sure if you were trying to keep this library super simple or not.

jtreher commented 2 years ago

I did start on this and have the basic concept working.

https://github.com/jtreher/c4sharp/commit/e7dd90b8bb28dcc0dd6a1109edb5d13bd250e0c9

I want to back my changes out of the existing test project(s) and create a new specifically to demo the tag functionality.

Also, I'd like to add XUnit to start getting some coverage up and running.

jtreher commented 2 years ago

yanjustino commented 2 years ago

@jtreher wow, dude! You read my mind... I already wrote some code to start this idea some time ago! Fill free to submit a PR to contemplate this feature!

https://github.com/8T4/c4sharp/blob/38d0696c7796dd9e490f4f727538341ddf33f67d/src/components/C4Sharp/Models/Structure.cs#L19

yanjustino commented 2 years ago

This issues was implemented. Please, see the Release 4.1.x! Thank you for your contribution.