search

8T4 / c4sharp

C4Sharp (C4S) is a .net library for building C4 Model diagrams.
MIT License
261 stars 37 forks source link

Updating PUMLs to current release version. #20

Closed jtreher closed 2 years ago

yanjustino commented 2 years ago

@jtreher thank you for your contributions! Before accepting your commit I need to fix how de library leads with standard C4 pluntuml files and embedded c4 resources. After that, I'll join your code in the main branch, OK?

best regards

jtreher commented 2 years ago

Oh, I didn't realize that this would be a breaking change. Please let me know if you need me to help with that.

Justin

On Mon, Nov 1, 2021 at 11:31 AM Yan Justino @.***> wrote:

@jtreher https://github.com/jtreher thank you for your contributions! Before accepting your commit I need to fix how de library leads with standard C4 pluntuml files and embedded c4 resources. After that, I'll join your code in the main branch, OK?

best regards

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/8T4/c4sharp/pull/20#issuecomment-956335647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJTFQ5J5QKQUOGGMYFFHMTUJ2XGXANCNFSM5G32WNEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

yanjustino commented 2 years ago

@jtreher no problem! I've worked on this fix! soon I'll publish a new version! I'd like this opportunity to appreciate your PR's and suggestions.

yanjustino commented 2 years ago

@jtreher sincerely, I need to set up de XUnit project and write tests...

jtreher commented 2 years ago

@yanjustino I have already started the xunit commit last night. I don't mind seeing the unit tests through to completion. I'm just not sure what approach will work best for some of the volatile static dependencies such as the file system. It might take some refactoring, so for now I will just cover what I can to avoid making code changes while introducing what can be covered. https://github.com/jtreher/c4sharp/tree/add-tests

yanjustino commented 2 years ago

@jtreher the last commit into the main branch contemplate the new version of this files. Also, I'd set up the test project on the solution.