search

8T4 / c4sharp

C4Sharp (C4S) is a .net library for building C4 Model diagrams.
MIT License
268 stars 38 forks source link

Feature/add svg generation #25

Closed bluekrow closed 2 years ago

bluekrow commented 2 years ago

Hello there! 👋 In our team we have been recently using the C4-Model to describe some legacy projects and the c4sharp nuget has been quite useful to our task! Thanks a lot for this project!!! 🙇

In the middle of this documentation task we had the need to export on svg format, and began to do it so manually, but taking a look at the c4sharp code, decided to give it a chance and create this PR, so it gets added to the nuget, if you consider so.

This change basically enables a call on the PlantumlSession class similar to UseDiagramImageBuilder which is UseDiagramSvgImageBuilder. This, in turn sets a GenerateDiagramSvgImages property From there, I implemented a private builder for the jar command, so the image format argument could be added from a method parameter. Finally, on the last commit, I also bumped the version number on the project file, and on the Github action file.

The PR can be better reviewed commit by commit.

If you have any suggestion to improve the PR, I'll be happy to receive it!

Thanks again, and happy coding! 😃

yanjustino commented 2 years ago

Thank you for this amazing feature and legible commits, @bluekrow. I'm grateful to you and your team to use C4Sharp and contributing to our project and the community. 👍🏽

bluekrow commented 2 years ago

Thank you for this amazing feature and legible commits, @bluekrow. I'm grateful to you and your team to use C4Sharp and contributing to our project and the community. 👍🏽

Thanks to you and your team for giving us this project. We are having a great time documenting our project with it!