search

8bitPit / Niagara-Issues

A place to submit feature requests and bug reports for Niagara Launcher, a modern + minimalist Android home screen optimized for one-✋ access and staying focused.
http://niagaralauncher.app
837 stars 40 forks source link

Frame drops when using haptics #1895

Open mohammad-malik opened 2 years ago

mohammad-malik commented 2 years ago

Describe the bug

When scrolling through the alphabetic app drawer list with haptic feedback on, it starts dropping frames and lagging.

Steps to reproduce

  1. Use a 90 Hz or above refresh rate device
  2. Install version 1.6.1 or above (versions with haptic feedback)
  3. Turn on haptic feedback and scroll through the list.
  4. Turn off haptic feedback and feel the difference.

Device name

OnePlus 7T Pro

Android version

Android 11

Screenshots / Screen recordings

I would add a screen recording but that don't go above 60 fps which doesnt show the problem.

TFackler commented 2 years ago

Hello there,

we will be looking into this and then get back to you :)

Oddward commented 2 years ago

There should be a way to show your fps count on-screen in developer options, try enabling that to confirm the frame rate drop and maybe record it

Yrlish commented 2 years ago

@TFackler I have started to experience the exact same bug when I woke up today with a new version with haptic feedback as default. I'm using a OnePlus Nord with Android 11.

Here is a recording where you can clearly see the difference. With haptic feedback enabled the render method is definitely lagging behind and does not give me the smooth 90 fps experience I've been used to. (Recording is around 24fps I think, so it's more obvious in person. Nonetheless, the visual difference is undeniable).

https://youtube.com/shorts/EjBc4VWsucM

It feels like there is something with the haptics blocking the render method, making it drop frames.

Maxr1998 commented 2 years ago

Indeed, I can reproduce frame drops when the haptic feedback is enabled on the scrollbar. I think we can provide a workaround which should reduce the stuttering a bit, but I believe there's an underlying issue in the framework that causes this to occur in the first place.

Msouza91 commented 2 years ago

Tried to replicate that on my device, but haven't been able to reproduce, enabled the frame counter on developer options and didn't have any frame drop with both settings, tried recording the evidence, but the screen recorder locks frame rate to 60 FPS.

https://user-images.githubusercontent.com/19522556/185794705-65e812af-c292-4db9-80ee-906a52a81cc3.mp4

I'm on A12 - S22 Ultra

Maxr1998 commented 2 years ago

It could be that it's fixed on Android 12. I also don't notice it on my Z fold4 which has Android 12. I could reproduce it on my Pixel 5 though which is still on Android 11.