8bitPit / Niagara-Issues

A place to submit feature requests and bug reports for Niagara Launcher, a modern + minimalist Android home screen optimized for one-✋ access and staying focused.
http://niagaralauncher.app
849 stars 41 forks source link

Features For Unthemed Icons! #1955

Closed Hexoline closed 2 years ago

Hexoline commented 2 years ago

Hi , as a Developer of Icon Pack , some of my users have missing features thats available in other Launcher like Nova Launcher about the Icon Masking , Icon Shade and Force Icon Shape , these 3 features for the unthemed icons are very good to have inside the Niagara launcher , not activated by default , but by users would be very good. Thanks!

Originally posted by @Hexoline in https://github.com/8bitPit/Niagara-Issues/issues/1820#issuecomment-1120452184

Amorphous404 commented 2 years ago

Yes, giving an option to turn on/off the masking for icon packs, and force reshape of icon packs would be such a great/must features for a launcher, i would definitely love to see this being added to Niagara

Oddward commented 2 years ago

Could this request be related to issue #1800 ? It seems there are plans to improve icon support with Android 13 opening up Material You icon APIs later. Atm there's limited support for dynamic icons like the Pix Material You icons

Amorphous404 commented 2 years ago

Could this request be related to issue #1800 ? It seems there are plans to improve icon support with Android 13 opening up Material You icon APIs later. Atm there's limited support for dynamic icons like the Pix Material You icons

Nope, not dynamic icons, adaptive means force reshaping of icons, and an option to turn of icon making etc

Screenshot_20220512-234738_Nova7.png

Oddward commented 2 years ago

there was already a response in the issue OP linked, I think you could keep the discussion in that issue if you have a case to make and request reopening it, there are a lot of separate issue just for icon theming already. Seems like the amount of request would end up with half the appearance settings being for icons 😅

Amorphous404 commented 2 years ago

there was already a response in the issue OP linked, I think you could keep the discussion in that issue if you have a case to make and request reopening it, there are a lot of separate issue just for icon theming already. Seems like the amount of request would end up with half the appearance settings being for icons 😅

I bet someone will even reopen it 😅, you guys are too fast at closing the issue

Nova launcher screenshot was just for clarification since you related it to dynamic icons,

There a quite lot of space for adding two toggles, these are a must two option any launcher should have,

1) auto making on/off 2) force reshape on/off

Screenshot_20220513-010836_Niagara Launcher.png

Amorphous404 commented 2 years ago

@Oddward

Since we are discussing about the icons, I'm not opening a separate ticket, idk if this a bug, but Niagara make use of one random icon mask for all the non supported icons instead of making use of all the others like the other launcher.

From This It Only Uses The Last Row 3rd Icon Screenshot_20220522-191832_MicoPacks.png

Here From Second Row 1st Icon Screenshot_20220522-191915_MicoPacks.png

Oddward commented 2 years ago

@topsy-turvy99 hmm ya this seems like a recent issue, I used to use RedlineX on an older device and it had dynamic masking, now tried it again after a while on a new one and I only see one mask being applied for unthemed icons instead of a variety of them. Since this is (seemingly) a bug rather than part of the request for theming features it could have its own issue

Amorphous404 commented 2 years ago

Okay, i wasn't sure if it was a bug, now it confirmed, should i open a separate ticket?

TFackler commented 2 years ago

@topsy-turvy99 Next time please do open a new issue when you notice something not originally mentioned by OP ;)

This is a known issue and has already been fixed. The fix will be included in the next major update 👍

TFackler commented 2 years ago

@Hexoline sadly I do not quite understand what features you would like us to add.

Icon masking using the Icon pack's masks automatically happens and use different masks (if applicable) starting with the next major update.

Could you clarify what you are talking about when referring to "forcing icon shape" and "icon shade"? Are you talking about adding a background to app icons not supported by the current icon pack?

Hexoline commented 2 years ago

"forcing icon shape" I mean for icons that are shapeless to have the same background shape as the icons included in the icon packs like circle , squircle , we as developers include the background shape for unthemed icons and for the adaptive icon packs will be awesome to have also a force to have all the same shape of the background.

github-actions[bot] commented 2 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. Without this, we don't have enough information to help you. Please comment below with the requested information if you still need help.

8bitPit commented 2 years ago

Sorry, this ticket was closed by accident, I'll reopen it

github-actions[bot] commented 2 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. Without this, we don't have enough information to help you. Please comment below with the requested information if you still need help.

8bitPit commented 2 years ago

well

TFackler commented 2 years ago

We do support icon packs which provide a custom background or border for icons not included in the pack. An example of this would be the "Västtraffik" and "Test Debug Application" app in the following screenshot.

image

We will not support adding backgrounds to icons supported by an icon pack however. I have already stated the reason why elsewhere:

We believe that icon packs however should allow their designer to have full control over how the icons look, so we want to respect their choice of using free form icons by not tampering with their background and shape. Therefore we will sadly not add this feature. If you have a specific icon pack you want to use with a certain background shape, please reach out to the pack creator and ask them for a version of the pack with the shape you desire.

from https://github.com/8bitPit/Niagara-Issues/issues/1820#issuecomment-1086613628

github-actions[bot] commented 2 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. Without this, we don't have enough information to help you. Please comment below with the requested information if you still need help.