search

8bitPit / Niagara-Issues

A place to submit feature requests and bug reports for Niagara Launcher, a modern + minimalist Android home screen optimized for one-✋ access and staying focused.
http://niagaralauncher.app
851 stars 41 forks source link

Text colour doesn't adapt to live wallpaper colour. #2806

Open RokeJulianLockhart opened 3 months ago

RokeJulianLockhart commented 3 months ago

Describe the bug

It used to be intermittent – possible to remediate by reinitialising Niagara, as https://github.com/8bitPit/Niagara-Issues/issues/2147#issuecomment-1419894675 and its linked issues explain – but it now never estimates it correctly.

Steps to reproduce

  1. Install https://www.apkmirror.com/apk/peter-huber/niagara-launcher-%f0%9f%94%b9-fresh-clean/niagara-launcher-%f0%9f%94%b9-fresh-clean-1-12-4-release/niagara-launcher-%e2%80%a7-home-screen-1-12-4-android-apk-download/.

  2. Set the font colour to adapt to the wallpaper colour:

    Screenshot_20240717-215555

  3. Install https://f-droid.org/repo/com.github.cvzi.darkmodewallpaper_59.apk.

  4. Apply #000000 as the wallpaper. (I have #ffffff set as the light mode wallpaper, and #000000 as the dark mode wallpaper.)

Does the issue also occur with other 3rd-party launchers?

Not applicable

Other 3rd-party launcher(s) tested

I don't know of any alternative launchers which support this feature.

Device name

cpe:/h:fairphone:fairphone_5

Android version

Android 13

Screenshots / Screen recordings

Screenshot_20240717-215219

TFackler commented 2 months ago

Thanks for reporting this.

Just making sure, you have set the text color to adapt to the wallpaper, correct? Because the screenshot you have provided shows the setting for the font to use rather than the color of it (Niagara Settings > Look > Text color).

RokeJulianLockhart commented 2 months ago

https://github.com/8bitPit/Niagara-Issues/issues/2806#issuecomment-2260699740

@TFackler, yeah, I have it set to automatic. Sorry for uploading the wrong screenshot.

TFackler commented 2 months ago

I could reproduce the issue the other way around, so I got light text on the white wallpaper and light text on the dark wallpaper. While this was readable, it could have been better.

I will look into this eventually, but until then, there seems to be an easy workaround with the specific app you mentioned.

Namely, in the app, go to Advanced settings > scroll to the part with a grid about what theme and text color to use: image

Set the text property to either dark or light depending on the wallpaper you will use for home/day and lock/day, as well as home/night and lock/night.

For me, I used white wallpaper for day and black wallpaper for night, so I would set home/day and lock/day to dark text (on white wallpaper) and set home/night and lock/night to light text (on black wallpaper). Then hit apply.

I hope this helps. Fixing this issue will be a low priority. Past experience showed that fixing this is difficult because the API for getting wallpaper colors is very restrictive.

RokeJulianLockhart commented 2 months ago

https://github.com/8bitPit/Niagara-Issues/issues/2806#issuecomment-2262406479

Those preferences work brilliantly:

Screenshot_20240801-110327

I'm really thankful. With such a simple workaround, it's of low priority to me too.