8bitbubsy / ft2-clone

Fasttracker 2 clone for Windows/macOS/Linux
https://16-bits.org
BSD 3-Clause "New" or "Revised" License
712 stars 48 forks source link

Playback of MOD isn't correct... Tested on orig FT2 and it plays correctly... #33

Closed ajack2001my closed 1 year ago

ajack2001my commented 2 years ago

FARLAND.zip

8bitbubsy commented 2 years ago

Can you please specify where it fails?

ajack2001my commented 2 years ago

sample 6, on channel 7, sequence 2 (pattern 0)...

8bitbubsy commented 2 years ago

Sounds identical. Do yo use an old version of the FT2 clone?

8bitbubsy commented 2 years ago

Result (tested against FT2.09): https://16-bits.org/etc/clone_then_real_ft2.mp3 For the testing, I set the FT2 clone to use linear interpolation. This makes it sound like real FT2 (although windowed-sinc interpolation is of higher quality).

ajack2001my commented 2 years ago

Sounds identical. Do yo use an old version of the FT2 clone?

v2.08... Run on Win 10_x64 via DOSBox

ajack2001my commented 2 years ago

Result (tested against FT2.09): https://16-bits.org/etc/clone_then_real_ft2.mp3 For the testing, I set the FT2 clone to use linear interpolation. This makes it sound like real FT2 (although windowed-sinc interpolation is of higher quality).

Ran with default settings on both

ajack2001my commented 2 years ago

ft2playback.zip This is the output I get...

8bitbubsy commented 2 years ago

That's sample 5, not 6. So I was looking at the wrong sample... Anyway, it seems like its loop point is completely wrong. I'll investigate.

ajack2001my commented 2 years ago

That's sample 5, not 6. So I was looking at the wrong sample... Anyway, it seems like its loop point is completely wrong. I'll investigate.

Sorry for the wrong info, my bad... :/

8bitbubsy commented 2 years ago

No problem. Going to release a new version of the FT2 clone with the fix today.

8bitbubsy commented 2 years ago

Ok, this has been fixed now. New version (v1.52) has been uploaded to https://16-bits.org/ft2.php

ajack2001my commented 2 years ago

Want to report your FT 2.11 for MS-DOS has the same problem... :p

8bitbubsy commented 2 years ago

Yep, I'm actually aware after testing it, and it's a shame. Not sure if I'll fix it in silence and not change the version number, or if I should bother at all...

ajack2001my commented 2 years ago

Yep, I'm actually aware after testing it, and it's a shame. Not sure if I'll fix it in silence and not change the version number, or if I should bother at all...

I'd suggest you fix it, version number isn't important... It is after all, the right thing to do. After you've put so much effort into this.

8bitbubsy commented 2 years ago

Fixed: https://16-bits.org/etc/FT211.ZIP