search

8bitbubsy / ft2-clone

Fasttracker 2 clone for Windows/macOS/Linux
https://16-bits.org
BSD 3-Clause "New" or "Revised" License
712 stars 48 forks source link

Link against LIBCMT.lib (/MT) instead of MSVCRT.lib (/MD) #37

Closed a740g closed 1 year ago

a740g commented 2 years ago

Hi @8bitbubsy

First I must congratulate your for the brilliant and excellent work you are doing.

I am sure you may have looked at this. However, I want to understand your choice of linking against the DLL version of MSCRT instead of the static version.

I see that you have a text file explaining folks to download and install the Microsoft Visual C++ Redistributable. However, you could avoid this by just linking against LIBCMT.lib (/MT) in the VS Solution. This will allow you to get rid of the above text file and save your users one step.

8bitbubsy commented 2 years ago

Simply because it causes way more false virus positives. I used to link the runtime in the earlier days.

8bitbubsy commented 2 years ago

Most users don't have to do a thing, as they already have the runtime installed. Unless you're talking about old Windows, of course.

a740g commented 2 years ago

Most users don't have to do a thing, as they already have the runtime installed. Unless you're talking about old Windows, of course.

Ok fair point. However, I ran into trouble when using this on an old version of Windows 10. Now I cannot recollect which version it was.

But the false virus positive thing is news to me.

Anyway, thank you for explaining. 👍